fix: remove Git CLI dependency and hide Windows command windows - #1800
Merged
Conversation
- remove the runtime dependency on the system Git executable - build memory baselines and diffs through vendored libgit2 - preserve ignored ad-hoc notes in Phase 2 workspace diffs - add regression coverage for ignored memory notes
wsp1911
marked this pull request as ready for review
July 27, 2026 10:40
- Hide MiniApp worker command windows on Windows. - Apply CREATE_NO_WINDOW to native hook execution. - Route local workspace shell and Docker workspace processes through the shared hidden-window command factory. - Cover local Docker probes, signals, and long-lived stdio transport execution.
wsp1911
force-pushed
the
fix/popup-window
branch
from
July 27, 2026 10:49
82f8192 to
f3db631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1749
Type and Areas
Type:
Bug fix / regression fix
Areas:
Rust core, services, agent runtime, desktop MiniApp runtime, Remote SSH
Motivation / Impact
Memory no longer requires a system Git installation to build workspace baselines or diffs. Ignored ad-hoc notes continue to participate in memory capture.
Windows release builds now create the affected background child processes with hidden console windows, including long-lived local Docker
docker execstdio sessions.Verification
pnpm run fmt:rsnode --check src/apps/desktop/resources/worker_host.jscargo test -p bitfun-services-core --features workspace-runtime workspacecargo test -p bitfun-services-integrations --features remote-ssh-concrete(49 passed; 1 Docker-dependent test ignored)cargo check -p bitfun-services-integrations --features remote-ssh-concretecargo check --workspaceReviewer Notes
memory_workspace_diff_includes_ignored_ad_hoc_notes.BITFUN_TEST_DOCKER_CONTAINER.Checklist